doc: add italoacasas to collaborators#9677
Closed
italoacasas wants to merge 1 commit intonodejs:masterfrom
italoacasas:doc/add-italoacasas-to-collaborators
Closed
doc: add italoacasas to collaborators#9677italoacasas wants to merge 1 commit intonodejs:masterfrom italoacasas:doc/add-italoacasas-to-collaborators
italoacasas wants to merge 1 commit intonodejs:masterfrom
italoacasas:doc/add-italoacasas-to-collaborators
Conversation
Member
|
LGTM |
Author
MylesBorins
approved these changes
Nov 18, 2016
Contributor
|
LGTM. For future reference @italoacasas there isn't a need to run CI for small doc fixes like this. edit: Also congrats 🎉 |
italoacasas
pushed a commit
that referenced
this pull request
Nov 18, 2016
PR-URL: #9677 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Author
|
Landed in: 38813c1. Thanks everyone |
Member
|
@thealphanerd I always have new collaborators start a CI on these onboarding PRs to confirm that they know how to start a CI job and that there isn't any issue with permissions on Jenkins etc. |
Contributor
|
@Trott thanks for the heads up @italoacasas sorry for the confusion there. |
MylesBorins
pushed a commit
that referenced
this pull request
Nov 18, 2016
PR-URL: #9677 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 18, 2016
PR-URL: #9677 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
|
@thealphanerd I guess I should also instruct them to add the relevant |
MylesBorins
pushed a commit
that referenced
this pull request
Nov 19, 2016
PR-URL: #9677 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Nov 22, 2016
PR-URL: #9677 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Adding
italoacasasto collaborators